Added new target support to Boolean, String, Number Object #4368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rerobika
requested changes
Dec 16, 2020
Comment on lines
589
to
592
| /** | ||
| * create class object operation. | ||
| * | ||
| * | ||
| * @return ecma value | ||
| * Returned value must be freed with ecma_free_value | ||
| */ |
There was a problem hiding this comment.
/**
* Create a ECMA_OBJECT_TYPE_CLASS object from the given arguments.
*
* @return ecma_value - constructed object
*/| ecma_value_t | ||
| ecma_op_create_class_object (ecma_builtin_id_t proto_id, /**< prototype id */ | ||
| ecma_value_t value, /**< ecma value */ | ||
| uint16_t lit_id) /**< magic string id */ |
| @@ -43,19 +45,30 @@ ecma_op_create_number_object (ecma_value_t arg) /**< argument passed to the Numb | |||
| { | |||
| ecma_number_t num; | |||
| ecma_value_t conv_to_num_completion = ecma_op_to_number (arg, &num); | |||
|
|
|||
| ecma_builtin_id_t proto_id; | |||
There was a problem hiding this comment.
Lower these declarations closer to these first usage.
| @@ -47,6 +49,8 @@ ecma_op_create_string_object (const ecma_value_t *arguments_list_p, /**< list of | |||
| || arguments_list_p != NULL); | |||
|
|
|||
| ecma_value_t prim_value = ecma_make_magic_string_value (LIT_MAGIC_STRING__EMPTY); | |||
| ecma_builtin_id_t proto_id; | |||
kisbg
force-pushed
the
newtarget-boolean
branch
from
ba97957 to
5eedb40
Compare
rerobika
requested changes
Dec 16, 2020
| /** | ||
| * Create a ECMA_OBJECT_TYPE_CLASS object from the given arguments. | ||
| * | ||
| * |
| @@ -43,19 +45,29 @@ ecma_op_create_number_object (ecma_value_t arg) /**< argument passed to the Numb | |||
| { | |||
| ecma_number_t num; | |||
| ecma_value_t conv_to_num_completion = ecma_op_to_number (arg, &num); | |||
|
|
|||
| @@ -47,7 +49,6 @@ ecma_op_create_string_object (const ecma_value_t *arguments_list_p, /**< list of | |||
| || arguments_list_p != NULL); | |||
|
|
|||
| ecma_value_t prim_value = ecma_make_magic_string_value (LIT_MAGIC_STRING__EMPTY); | |||
|
|
|||
kisbg
force-pushed
the
newtarget-boolean
branch
from
5eedb40 to
7c8646d
Compare
zherczeg
requested changes
Dec 16, 2020
| ecma_object_t *prototype_obj_p = ecma_builtin_get (proto_id); | ||
|
|
||
| #if ENABLED (JERRY_ESNEXT) | ||
| if (JERRY_CONTEXT (current_new_target)) |
There was a problem hiding this comment.
I would copy this into a local variable.
| @@ -35,6 +35,7 @@ | |||
| #include "ecma-string-object.h" | |||
| #include "ecma-symbol-object.h" | |||
| #include "jrt-libc-includes.h" | |||
| #include "jcontext.h" | |||
| @@ -42,13 +44,27 @@ ecma_value_t | |||
| ecma_op_create_boolean_object (ecma_value_t arg) /**< argument passed to the Boolean constructor */ | |||
There was a problem hiding this comment.
An important question: is this only used by constructors? Because if it is used elsewhere, it must not use the new target. This is also true for all other functions.
There was a problem hiding this comment.
Yes, only used ecma_builtin_boolean_dispatch_construct.
| @@ -9668,7 +9666,6 @@ | |||
| <test id="built-ins/RegExp/prototype/sticky/cross-realm.js"><reason></reason></test> | |||
| <test id="built-ins/RegExp/prototype/unicode/cross-realm.js"><reason></reason></test> | |||
| <test id="built-ins/SharedArrayBuffer/proto-from-ctor-realm.js"><reason></reason></test> | |||
| <test id="built-ins/String/proto-from-ctor-realm.js"><reason></reason></test> | |||
There was a problem hiding this comment.
Only realm tests are fixed? No normal tests for these?
There was a problem hiding this comment.
Sadly, there is no new target test for boolean, string and number object.
JerryScript-DCO-1.0-Signed-off-by: bence gabor kis [email protected]
kisbg
force-pushed
the
newtarget-boolean
branch
from
7c8646d to
5a63e0f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JerryScript-DCO-1.0-Signed-off-by: bence gabor kis [email protected]