Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the include directory in the pkgconfig of the math lib #4414

Merged
merged 1 commit into from
Jan 8, 2021

Conversation

akosthekiss
Copy link
Member

The pkgconfig specified include/jerry-math as the include
directory, but cmake installs header to include/jerryscript-math.

JerryScript-DCO-1.0-Signed-off-by: Akos Kiss [email protected]

The pkgconfig specified `include/jerry-math` as the include
directory, but cmake installs header to `include/jerryscript-math`.

JerryScript-DCO-1.0-Signed-off-by: Akos Kiss [email protected]
@akosthekiss akosthekiss added the jerry-libm Related to the jerry-libm library label Jan 5, 2021
Copy link
Member

@rerobika rerobika left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@dbatyai dbatyai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dbatyai dbatyai merged commit 29785b2 into jerryscript-project:master Jan 8, 2021
@akosthekiss akosthekiss deleted the fix-math-pc-incdir branch January 8, 2021 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jerry-libm Related to the jerry-libm library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants