Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix buffer size calculation in Number.prototype.toString() #449

Conversation

dbatyai
Copy link
Member

@dbatyai dbatyai commented Jul 22, 2015

This is a fix for issue #445.

JerryScript-DCO-1.0-Signed-off-by: Dániel Bátyai [email protected]

@dbatyai dbatyai added bug Undesired behaviour ecma builtins Related to ECMA built-in routines labels Jul 22, 2015
@dbatyai dbatyai added this to the ECMA builtins milestone Jul 22, 2015
@egavrin
Copy link
Contributor

egavrin commented Jul 24, 2015

Good to me

@galpeter
Copy link
Contributor

looks good to me

@dbatyai dbatyai force-pushed the number_tostring_buffer_calc_fix branch 2 times, most recently from c8f5094 to 50df91b Compare July 24, 2015 11:22
JerryScript-DCO-1.0-Signed-off-by: Dániel Bátyai [email protected]
@dbatyai dbatyai force-pushed the number_tostring_buffer_calc_fix branch from 50df91b to d1e11e0 Compare July 24, 2015 11:24
@galpeter
Copy link
Contributor

Landed: b110070

@galpeter galpeter closed this Jul 24, 2015
@dbatyai dbatyai deleted the number_tostring_buffer_calc_fix branch July 31, 2015 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Undesired behaviour ecma builtins Related to ECMA built-in routines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants