Remove a wrong test not to slow down test262-es2015 #4542
Conversation
Since ES2018 iterator's next method is called once during the prologue of iteration, rather than during each step. The test is incorrect and stuck in an infinite loop. tc39/test262#1248 fixed the test and it passes on test262-esnext. Removing test/language/statements/for-of/iterator-next-reference.js from test262-es2015 is necessary, because it won't pass ever and only slow down testing. JerryScript-DCO-1.0-Signed-off-by: Csaba Osztrogonác [email protected]
|
Note: It is needed to be able to increase timeout for debug tests. (#4456) |
|
If we land this, and move to another test262 version, will there be a notification to remove this workaround? |
It affects only the es2015 version of test262 which is a fixed git revision. We can drop this workaround when we drop es2015 version of test262. |
|
Do we still need it? We don't have es2015 support anymore. |
I don't think if we should drop test262-es2015 until we make all supported feature compatible with ES11 (ES2020), |
Hi, maybe using a exclude-list and pass into test262-harness instead? All tests that failed because upgrade to es2020 should be |
On the CI we always run tests with update option (to see not only regressions, but progressions too), which doesn't use exclude list at all. |
Make sense, after this pull request, we can increase the timeout value to a very large value such as 5minutes, LGTM |
Since ES2018 iterator's next method is called once during the prologue of iteration,
rather than during each step. The test is incorrect and stuck in an infinite loop.
tc39/test262#1248 fixed the test and it passes on test262-esnext.
Removing test/language/statements/for-of/iterator-next-reference.js from test262-es2015
is necessary, because it won't pass ever and only slow down testing.
JerryScript-DCO-1.0-Signed-off-by: Csaba Osztrogonác [email protected]