Implement String.prototype.replace function. #474
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
25 tasks
zherczeg
force-pushed
the
string-prototype-replace-dev
branch
from
5aa7e40 to
4d4c4f8
Compare
| ecma_length_t end, /**< end position */ | ||
| bool free_base_string) /**< free base string or not */ | ||
| { | ||
| ecma_string_t *appended_string; |
There was a problem hiding this comment.
The variable name is very similar to argument's name appended_string_p. Maybe, ret_string_p would be better.
|
Could you, please, add note to |
zherczeg
force-pushed
the
string-prototype-replace-dev
branch
2 times, most recently
from
d5442ba to
f8a55f7
Compare
|
I think I did the requested changes. |
| context_p->input_length, | ||
| true); | ||
| } | ||
| else if (action != LIT_CHAR_NULL) |
There was a problem hiding this comment.
The condition is always true.
|
@zherczeg, thank you for the update! After updating #474 (comment), #474 (comment), the changes would look good to me. |
zherczeg
force-pushed
the
string-prototype-replace-dev
branch
from
f8a55f7 to
b82664b
Compare
|
Thank you for the review. I added two new tests. |
JerryScript-DCO-1.0-Signed-off-by: Zoltan Herczeg [email protected]
zherczeg
force-pushed
the
string-prototype-replace-dev
branch
from
b82664b to
f1c178c
Compare
|
lgtm |
|
Looks good to me |
|
|
|
Landed 048e209 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JerryScript-DCO-1.0-Signed-off-by: Zoltan Herczeg [email protected]