Implement String.prototype.lastIndexOf() #483
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The helper function is prepared to handle indexOf() as well, it will be adjusted in a separate step. |
| { | ||
| /* match as long as possible */ | ||
| ecma_length_t match_len = 0; | ||
| lit_utf8_iterator_pos_t stored_original_pos = lit_utf8_iterator_get_pos (&original_it); |
There was a problem hiding this comment.
Can't we save the iterator itself? Seeking is not a cheap operation.
dbatyai
added
ecma builtins
lvidacs
force-pushed
the
string-prototype-lastindexof
branch
from
790d120 to
7f758fe
Compare
25 tasks
| extern ecma_completion_value_t ecma_builtin_helper_string_prototype_object_index_of (ecma_value_t this_arg, | ||
| ecma_value_t arg1, | ||
| ecma_value_t arg2, | ||
| bool firstIndex); |
lvidacs
force-pushed
the
string-prototype-lastindexof
branch
from
7f758fe to
a1e0185
Compare
|
@galpeter, thanks for the comments, the patch is rebased and updated. |
| if (match_len == search_len) | ||
| { | ||
| *ret_num_p = ecma_uint32_to_number (index); | ||
| found = true; |
There was a problem hiding this comment.
Do we need the found at all? Can't we just break out?
JerryScript-DCO-1.0-Signed-off-by: Laszlo Vidacs [email protected]
lvidacs
force-pushed
the
string-prototype-lastindexof
branch
from
a1e0185 to
11a6a50
Compare
|
lgtm |
|
looks good, but please open an issue that where the followup work is described |
|
Issue #515 is opened for follow-up work. |
|
|
|
Landed in 554305d |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JerryScript-DCO-1.0-Signed-off-by: Laszlo Vidacs [email protected]