Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RegExp constructor when called with undefined arguments #492

Merged

Conversation

dbatyai
Copy link
Member

@dbatyai dbatyai commented Jul 29, 2015

The RegExp constructor does not work correctly in some cases when one of it's arguments is undefined.

@dbatyai dbatyai added bug Undesired behaviour ecma builtins Related to ECMA built-in routines labels Jul 29, 2015
@dbatyai dbatyai added this to the ECMA builtins milestone Jul 29, 2015
@egavrin
Copy link
Contributor

egavrin commented Jul 29, 2015

Good to me

@zherczeg
Copy link
Member

LGTM

JerryScript-DCO-1.0-Signed-off-by: Dániel Bátyai [email protected]
@dbatyai dbatyai force-pushed the regexp_constructor_undefined_flags branch from a36e7eb to 39cf5aa Compare July 30, 2015 07:47
@dbatyai dbatyai merged commit 39cf5aa into jerryscript-project:master Jul 30, 2015
@dbatyai dbatyai deleted the regexp_constructor_undefined_flags branch July 31, 2015 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Undesired behaviour ecma builtins Related to ECMA built-in routines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants