Implement String.prototype.search, and some minor regexp refactors. #504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any thoughts? |
25 tasks
| @@ -31,6 +31,10 @@ | |||
| #include "jrt-libc-includes.h" | |||
| #include "lit-char-helpers.h" | |||
|
|
|||
| #ifndef CONFIG_ECMA_COMPACT_PROFILE_DISABLE_REGEXP_BUILTIN | |||
| #include "ecma-regexp-object.h" | |||
| #endif | |||
There was a problem hiding this comment.
Usually, #endif is followed by a condition, under which block above is executed.
In the case: /* !CONFIG_ECMA_COMPACT_PROFILE_DISABLE_REGEXP_BUILTIN */
|
I've got no other comments. |
JerryScript-DCO-1.0-Signed-off-by: Zoltan Herczeg [email protected]
zherczeg
force-pushed
the
string-prototype-search-dev
branch
from
cfb4635 to
23b41ff
Compare
|
Thank you. Your comments were fixed. |
|
Looks good to me. |
|
|
egavrin
added
enhancement
|
Landed in 0a1b6eb |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JerryScript-DCO-1.0-Signed-off-by: Zoltan Herczeg [email protected]