Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the this argument passed to string replace callbacks. #562

Closed
wants to merge 1 commit into from
Closed

Fix the this argument passed to string replace callbacks. #562

wants to merge 1 commit into from

Conversation

zherczeg
Copy link
Member

JerryScript-DCO-1.0-Signed-off-by: Zoltan Herczeg [email protected]

Fixes
15.5.4.11-1.js and S15.5.4.11_A12.js

@zherczeg
Fix the this argument passed to string replace callbacks.
69c32d8 
JerryScript-DCO-1.0-Signed-off-by: Zoltan Herczeg [email protected]
@egavrin egavrin added bug Undesired behaviour ecma builtins Related to ECMA built-in routines labels Aug 11, 2015
@egavrin
Copy link
Contributor

egavrin commented Aug 11, 2015

Good to me

@egavrin egavrin assigned galpeter and unassigned egavrin Aug 11, 2015
@dbatyai
Copy link
Member

dbatyai commented Aug 11, 2015

lgtm

@egavrin egavrin assigned zherczeg and unassigned galpeter Aug 11, 2015
@zherczeg
Copy link
Member Author

Landed in f2c846d

@zherczeg zherczeg closed this Aug 11, 2015
@zherczeg zherczeg deleted the string-replace-fixes branch August 11, 2015 13:29
@zherczeg zherczeg mentioned this pull request Jul 20, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@zherczeg zherczeg

Labels
bug Undesired behaviour ecma builtins Related to ECMA built-in routines
Projects
None yet
Milestone
Maintenance of ECMA functionality
Development

Successfully merging this pull request may close these issues.
4 participants
@zherczeg @egavrin @dbatyai @galpeter