Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve compiler detection for x86_64 target #73

Merged
merged 1 commit into from
May 19, 2015

Conversation

galpeter
Copy link
Contributor

Related issue: #71

JerryScript-DCO-1.0-Signed-off-by: Peter Gal [email protected]

@egavrin egavrin added enhancement An improvement infrastructure Related to GH Actions or the tested targets labels May 15, 2015
@ruben-ayrapetyan
Copy link
Contributor

@galpeter ,
The way to search for compiler is ok.
However, it seems that using strip if x86-64-[unknown-]-linux-gnu-strip is not found, could break cross compilation to x86_64, as the strip would probably refer to version for host architecture, not the target.

Please add "FIXME" comment to line for finding strip with the following content:
"# FIXME: This can break cross compilation to x86_64, when it would be supported".

Then merge the commit to master through rebasing, fast-forward merge and make push.

After that, please, raise an issue for the FIXME, sufficiently describing why the change is necessary,
how this can affect cross compilation, and reference to the commit.
If there are any ideas how the issue could be fixed, please add them also.

@galpeter
Copy link
Contributor Author

@ruben-ayrapetyan
Would it be ok to reuse the #71 issue?

@egavrin
Copy link
Contributor

egavrin commented May 19, 2015

@galpeter yes, it'd OK.

JerryScript-DCO-1.0-Signed-off-by: Peter Gal [email protected]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An improvement infrastructure Related to GH Actions or the tested targets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants