Implement Array.prototype.splice(). #86
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
25 tasks
|
lgtm |
| ecma_op_to_object (this_arg), | ||
| ret_value); | ||
|
|
||
| ecma_object_t* obj_p = ecma_get_object_from_value (obj_this); |
There was a problem hiding this comment.
AFAIK: the * should be at the variable.
|
@galpeter fixed |
|
|
||
| /* 15. */ | ||
| ecma_length_t idx = 0; | ||
| for (ecma_length_t arg_index = 2; |
There was a problem hiding this comment.
Because the first two argument are the start_index and the delete_count usually.
If the args_number is less than or equal to 2, then the condition of the loop will be false (we shouldn't put items into the array).
|
|
|
|
||
| /* 11. */ | ||
| ecma_length_t item_count; | ||
| if (args_number > 2) |
There was a problem hiding this comment.
Add blank line before if, please.
JerryScript-DCO-1.0-Signed-off-by: Zsolt Borbély [email protected]
|
rebased & merged: dd94064 |
This was referenced May 17, 2020
This was referenced Oct 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JerryScript-DCO-1.0-Signed-off-by: Zsolt Borbély [email protected]