Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README.md: add an hello.js example #884

Closed
wants to merge 0 commits into from

Conversation

zoobab
Copy link

@zoobab zoobab commented Feb 15, 2016

No description provided.

@@ -22,6 +22,19 @@ cd jr
make release.linux -j
```

This is producing an executable named "jerry" in "build/bin/release.linux/".
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd merge this in the subsection below, e.g., "Once the executable jerry is built in ... ...

@zoobab
Copy link
Author

zoobab commented Feb 15, 2016

@akiss77 as you wish for the syntax. It took me a while to find out how to make an "hello world", I think this is needed.

@akosthekiss
Copy link
Member

@zoobab No question there (at least from my side). If you could update you patch, we could merge it in quite soon (I think/hope).

@LaszloLango LaszloLango added the documentation Related to documentation label Feb 15, 2016
@LaszloLango
Copy link
Contributor

@zoobab, I know that the current documentation must be improved, so any help with it is welcome. :) Please update your PR based on comments of @akiss77.

@LaszloLango
Copy link
Contributor

@zoobab, please add your Sign-off to the commit message:
JerryScript-DCO-1.0-Signed-off-by: Benjamin Henrion [email protected]

@akosthekiss
Copy link
Member

The second patch in the PR seems to me as a somewhat unrelated change. This PR was about improving the docs, wasn't it? I'd prefer discussing test/example suite additions in a separate PR.
(BTW, copyright year is incorrect.)

@akosthekiss
Copy link
Member

@zoobab You seem to use the branch associated with this PR as your working branch. I just realize that this is your master branch. Now, you have 13 patches here. That's not quite aligned with the traditional git/github workflow. Do you really want any of these changes get merged into the project?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Related to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants