Add support for travis-ci integration #886
Merged
+82
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akosthekiss
added
enhancement
akosthekiss
force-pushed
the
travis-integration
branch
2 times, most recently
from
16f8275 to
935ce71
Compare
| - os: osx | ||
|
|
||
| #branches: | ||
| # only: master |
There was a problem hiding this comment.
If we don't need this, then remove it please (or uncomment if we do).
There was a problem hiding this comment.
That's something to be decided. That's why I've left it there, to show that we have an option. But I can delete those lines ofc.
|
LGTM |
akosthekiss
force-pushed
the
travis-integration
branch
from
935ce71 to
a7e9ec7
Compare
|
Updated (removed the comments) |
akosthekiss
force-pushed
the
travis-integration
branch
from
d791b11 to
f169a3d
Compare
|
Ready for landing. Does it need a squash before the merge? |
|
@akiss77, sure, you may land this. And yes, squash it please. Our policy is to squash all the commits into one and one commit will belongs to one PR on the master. There are a few exceptions when the patch is too huge. We can change this policy, but not now :) You could raise an issue if you think this should be changed. |
Fully fledged checks, builds, and tests on Linux, non-voting native builds and unit tests on OS X. JerryScript-DCO-1.0-Signed-off-by: Akos Kiss [email protected]
akosthekiss
force-pushed
the
travis-integration
branch
from
f169a3d to
b18591e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fully fledged checks, builds, and tests on Linux, non-voting native builds and unit tests on OS X.