Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implemented Array.prototype.filter() #89

Closed
wants to merge 1 commit into from
Closed

Implemented Array.prototype.filter() #89

wants to merge 1 commit into from

Conversation

dbatyai
Copy link
Member

@dbatyai dbatyai commented May 21, 2015

JerryScript-DCO-1.0-Signed-off-by: Dániel Bátyai [email protected]

@ILyoan ILyoan mentioned this pull request May 21, 2015
Closed
25 tasks
@galpeter galpeter added this to the ECMA builtins milestone May 21, 2015
@dbatyai dbatyai added the ecma builtins Related to ECMA built-in routines label May 22, 2015
@galpeter
Copy link
Contributor

lgtm

ruben-ayrapetyan
ruben-ayrapetyan reviewed May 26, 2015
View reviewed changes
jerry-core/ecma/builtin-objects/ecma-builtin-array-prototype.cpp
ecma_op_object_get (obj_p, magic_string_length_p),
ret_value);

ECMA_OP_TO_NUMBER_TRY_CATCH (len_number, len_value, ret_value);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is part of step 3, isn't it?

@ruben-ayrapetyan ruben-ayrapetyan self-assigned this May 26, 2015
ruben-ayrapetyan
ruben-ayrapetyan reviewed May 27, 2015
View reviewed changes
jerry-core/ecma/builtin-objects/ecma-builtin-array-prototype.cpp
to_index_string_p,
get_value,
false);
JERRY_ASSERT (ecma_is_completion_value_normal (put_comp_value));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, change the assertion to ecma_is_completion_value_normal_true (put_comp_value).

@dbatyai
Copy link
Member Author

dbatyai commented May 28, 2015

I've updated the patch.

@egavrin
Copy link
Contributor

egavrin commented May 28, 2015 

/jerry-core/ecma/builtin-objects/ecma-builtin-array-prototype.cpp: In function ‘ecma_completion_value_t ecma_builtin_array_prototype_object_filter(ecma_value_t, ecma_value_t, ecma_value_t)’:
/jerry-core/ecma/builtin-objects/ecma-builtin-array-prototype.cpp:794:49: error: ‘to_object_comp’ was not declared in this scope
     func_object_p = ecma_get_object_from_value (to_object_comp);
                                                 ^
compilation terminated due to -Wfatal-errors.

ruben-ayrapetyan
ruben-ayrapetyan reviewed May 28, 2015
View reviewed changes
jerry-core/ecma/builtin-objects/ecma-builtin-array-prototype.cpp
ecma_deref_ecma_string (index_str_p);
}

ecma_free_completion_value (to_object_comp);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the to_object_comp? Why should it be freed?

@dbatyai
Copy link
Member Author

dbatyai commented May 28, 2015

@egavrin, @ruben-ayrapetyan sorry, fixed

@dbatyai @szledan
Implemented Array.prototype.filter()
a80282a 
JerryScript-DCO-1.0-Signed-off-by: Dániel Bátyai [email protected]
@ruben-ayrapetyan
Copy link
Contributor

make push

@egavrin
Copy link
Contributor

egavrin commented May 28, 2015

@dbatyai @ruben-ayrapetyan Nope ^_^, wrong email

+ make precommit -j4
�[1;33m Signed-off-by message is incorrect. The following line should be at the end of the ed47d2279a9758ee3e82f7dac87f3dccdd9dc566 commit's message: 'JerryScript-DCO-1.0-Signed-off-by: Dániel Bátyai [email protected]'.

@ruben-ayrapetyan
Copy link
Contributor

@egavrin , ed47d2279a9758ee3e82f7dac87f3dccdd9dc566 seems to be another commit.
The commit in the pull request is a80282a.

In other, already merged, commits the [email protected] e-mail is used.

@egavrin
Copy link
Contributor

egavrin commented May 28, 2015

@ruben-ayrapetyan ah, my bad.
make push

@dbatyai
Copy link
Member Author

dbatyai commented May 28, 2015

merged: 3329583

@dbatyai dbatyai closed this May 28, 2015
@ruben-ayrapetyan ruben-ayrapetyan removed their assignment May 28, 2015
@dbatyai dbatyai deleted the array_prototype_filter branch June 9, 2015 14:04
@zherczeg zherczeg mentioned this pull request Jul 20, 2016
Closed
This was referenced May 17, 2020
Closed
Closed
This was referenced Oct 20, 2020
Closed
Closed
Closed
@kvenux kvenux mentioned this pull request Oct 20, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ecma builtins Related to ECMA built-in routines
Projects
None yet
Milestone
ECMA builtins
Development

Successfully merging this pull request may close these issues.
5 participants
@dbatyai @galpeter @egavrin @ruben-ayrapetyan @tilmannOSG