Get the alpha order of lexer keywords right #891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akosthekiss
added
bug
|
LGTM. The list is scanned lineraly, so ordering is not relevant, but we might use a binary search later, so this is a good catch. |
Two keywords violate the ordering. Should someone depend on the alpha order in the future (because the `keyword_length_*` arrays seem to be ordered)` then this issue will be a nightmare to debug. Better get this right now. JerryScript-DCO-1.0-Signed-off-by: Akos Kiss [email protected]
akosthekiss
force-pushed
the
lexer-keyword-order
branch
from
00f806e to
b2f3ec2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two keywords violate the ordering. Should someone depend on the
alpha order in the future (because the
keyword_length_*arraysseem to be ordered) then this issue will be a nightmare to debug.
Better get this right now.
JerryScript-DCO-1.0-Signed-off-by: Akos Kiss [email protected]