Improve the usability of test runner scripts #909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akosthekiss
added
enhancement
|
I like simplifications, LGTM |
|
LGTM |
* First of all, remove the counter-intuitive "OUT_DIR" second argument of run-test-suite.sh. This, way, the invocation of the script becomes easier to remember: `tools/runners/run-test-suite.sh <engine> <testsuite>` However, this also means that all output files (lists of executed, passed, and failed tests) are generated in the current working directory. * Align the behaviour of run-unittests.sh with the above, i.e., don't try to guess where to put output files but write them in the CWD. * Adapt Makefile to the change in the use of the test runner scripts: create and change to "check" directories before invoking test runner scripts. Extras: * tools/runners/run-test-suite.sh collected fail tests from directories twice. This does no harm but is inefficient, thus removing. * tools/runners/run-test-suite.sh was too permissive on the contents of test suite list files. Better to accept those lines only which really contain paths to JS test files. JerryScript-DCO-1.0-Signed-off-by: Akos Kiss [email protected]
akosthekiss
force-pushed
the
test-runner-usability
branch
from
1c94e8b to
d857fe0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
argument of run-test-suite.sh. This, way, the invocation of the
script becomes easier to remember:
tools/runners/run-test-suite.sh <engine> <testsuite>However, this also means that all output files (lists of
executed, passed, and failed tests) are generated in the current
working directory.
don't try to guess where to put output files but write them in
the CWD.
scripts: create and change to "check" directories before invoking
test runner scripts.
Extras:
directories twice. This does no harm but is inefficient, thus
removing.
contents of test suite list files. Better to accept those lines
only which really contain paths to JS test files.
JerryScript-DCO-1.0-Signed-off-by: Akos Kiss [email protected]