Fix terminology of snapshot saving in literals #953
Conversation
|
I am ok with this patch, but could it wait until #948 landed, and do a rebase after? |
|
@zherczeg What's the time frame for that? If that takes longer, why not the other way around? |
|
@akiss77, the term |
|
@LaszloLango You are right, dump is even used in the name of a command line switch. (Which is a pitty, since the public api calls it 'save', too.) I've missed that, focusing only on jerry-core. I'm not sure how to deal with that since I know at least about iot.js using the command line switch. (Ofc, we can decide to rename everything here, including the command line switch, and adapt iot-js to that when it gets rebased to latest jerry.) Opinions? |
|
I think we should rename everywhere, but the http://samsung.github.io/jerryscript/benchmark/benchmark.html?show=sum site use snapshot somehow. It may use only the load. AFAIK @wateret maintains the benchmark. |
akosthekiss
force-pushed
the
lit-snapshot-save
branch
from
b66e8e9 to
0dc4f90
Compare
|
Updated (changed terminology in main-unix.cpp as well). |
In case of literals and in main, snapshot saving is incorrectly named dumping. Elsewhere in the code, 'dump' functions output debug data (even literals have a `lit_dump_literals` debug function). To help distinction and to align terminologies, snapshot saving functions of literals and command line options of main are also re-named 'save'. JerryScript-DCO-1.0-Signed-off-by: Akos Kiss [email protected]
akosthekiss
force-pushed
the
lit-snapshot-save
branch
from
0dc4f90 to
ea2f0e4
Compare
|
Now that #948 got landed, what about this PR? (Rebased, resolved conflicts, pushed.) |
|
LGTM |
1 similar comment
|
LGTM |
In case of literals, snapshot saving is incorrectly named dumping.
Elsewhere in the code, 'dump' functions output debug data (even
literals have a
lit_dump_literalsdebug function). To helpdistinction and to align terminologies, snapshot saving functions
of literals are also re-named 'save'.
JerryScript-DCO-1.0-Signed-off-by: Akos Kiss [email protected]