Remove support for per-instruction memory statistics #954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -36,8 +36,7 @@ extern "C" | |||
| #define JERRY_FLAG_SHOW_OPCODES (1u << 0) /**< dump byte-code to stdout after parse */ | |||
| #define JERRY_FLAG_MEM_STATS (1u << 1) /**< dump memory statistics */ | |||
| #define JERRY_FLAG_MEM_STATS_PER_OPCODE (1u << 2) /**< dump per-instruction memory statistics during execution | |||
| * (in the mode full GC is performed after execution of each | |||
| * opcode handler) */ | |||
| * FIXME: Remove. */ | |||
There was a problem hiding this comment.
I wasn't sure whether I should renumber all unrelated flags or leave an unused hole in the bits. But I'd go for the renumbering then.
There was a problem hiding this comment.
Could you also change the style of the flags to be an enum?
There was a problem hiding this comment.
Note that these are bit flags that can be combined (or'd). Do we use enums for such constructs? If we'd like to go for a change then bitfield structs seem a better fit to me. If.
There was a problem hiding this comment.
See re_flags_t and ecma_property_flags_t
There was a problem hiding this comment.
I also prefer enum. see vm/vm.h
LGTM after that
akosthekiss
force-pushed
the
remove-mem-stats-per-opcode
branch
from
cb672e9 to
11dc376
Compare
|
Updated according to the reviews. |
The new CBC interpreter does not support it anymore, thus removing related code. (As a side-effect, `jerry_flag_t` has been refactored from `uint32_t` and associated defines to an enum.) JerryScript-DCO-1.0-Signed-off-by: Akos Kiss [email protected]
akosthekiss
force-pushed
the
remove-mem-stats-per-opcode
branch
from
11dc376 to
6e687fa
Compare
|
LGTM |
1 similar comment
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new CBC interpreter does not support it anymore.
JerryScript-DCO-1.0-Signed-off-by: Akos Kiss [email protected]