-
Notifications
You must be signed in to change notification settings - Fork 308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add functionality to read rules from a folder #1236
Add functionality to read rules from a folder #1236
Conversation
Thanks for the submission! I don't see a reason not to include this so please proceed with documentation and changelog updates. Also, I think your PR accidentally included changes to default values, and some formatting changes. Please revert those since they don't appear to be part of your new feature. |
Thanks for the comment. Really looking forward to contribute more! |
Fix changelog syntax
Correct indentation of rules template, caused by #1236
Description
The problem I tried to solve was organizing our rules in my workplace, we had so many rules and maintaining them was getting kind of hard.
The solution was somewhat simple, the rules configMap needed to be updated so that it reads from a folder and scans all files with
.yaml
extension and build the rules configMap from them.I hope this feature helps you too because now our rules are much more cleaner and maintainable.
Thanks for this awesome project as well.
with this feature all rules can be in its own folder and you just need to pass the folder name to the rootRulesFolder in the values.yaml
Checklist
make test-docker
with my changes.Questions or Comments
I am waiting for your comments, if everything is ok then I can write the documentation and etc. for this PR.