Correct deployment commonLabels indentation for pod template #1250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I noticed when using the
commonLabelsvalue that the deployment was unable to render additional labels correctly. It looks like the pod template specific template's indentation was off by 4 spaces.Checklist
make test-dockerwith my changes.Questions or Comments
As this is a minor indentation change specific to the Helm chart, the testing didn't seem to be relevant but please correct me if I'm wrong! I've tested the indentation locally and the manifests seem to be rendering correctly now when adding
commonLabels.