Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating the IRIS alerter for scenarios where fields are requested fr… #1352

Merged
merged 3 commits into from
Jan 8, 2024
Merged

Updating the IRIS alerter for scenarios where fields are requested fr… #1352

merged 3 commits into from
Jan 8, 2024

Conversation

malinkinsa
Copy link
Contributor

@malinkinsa malinkinsa commented Jan 8, 2024 •
edited
Loading

Following the discussion's trail. #1348

Description

There was an issue with nested JSON within the document. The values from them weren't being passed into the fields.

Checklist

  • I have reviewed the contributing guidelines.
  • I have included unit tests for my changes or additions.
  • I have successfully run make test-docker with my changes.
  • I have manually tested all relevant modes of the change in this PR.
  • I have updated the documentation.
  • I have updated the changelog.

jertel
jertel approved these changes Jan 8, 2024
View reviewed changes
Copy link
Owner

@jertel jertel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @malinkinsa

@jertel jertel merged commit 93f8510 into jertel:master Jan 8, 2024
1 check passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jertel jertel jertel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@malinkinsa @jertel