Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Login Placeholder not localized #336

Closed
1 task done
Kiina opened this issue Jun 22, 2021 · 2 comments
Closed
1 task done

Login Placeholder not localized #336

Kiina opened this issue Jun 22, 2021 · 2 comments

Comments

@Kiina
Copy link
Contributor

Kiina commented Jun 22, 2021

Type: Bug Report

  • Try to follow the update procedure described in the README and try again before opening this issue.

Running the latest Version from github I noticed the form on login isn't localized like other forms:

image

Should be the corresponding part in the code:

flood/client/src/javascript/components/auth/AuthForm.tsx

Lines 119 to 123 in 5e6d5c3

<Textbox placeholder="Username" id="username" autoComplete="username" />
</FormRow>
<FormRow>
<Textbox
placeholder="Password"

jesec added a commit that referenced this issue Jun 25, 2021
@jesec
AuthForm: add missing i18n for "Username" and "Password"
6a565f9 
Bug: #336
@jesec
Copy link
Owner

jesec commented Jun 25, 2021

👍 Please check out the latest build.

@Kiina
Copy link
Contributor Author

Kiina commented Jun 25, 2021

Perfect, working great

@Kiina Kiina closed this as completed Jun 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Kiina @jesec