client: fix loading indicator bar alignment #396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DopyConqueror
force-pushed
the
loading-indicator-fix
branch
from
c34df26 to
544a89f
Compare
|
My account got flagged and got shadow banned for a couple of days, which hid my PRs, too. Everything is back to normal and I rebased onto master, so this PR is ready for review. |
|
any screenshot (before and after)? |
|
On the left is the current alignment and on the bottom the bar has a height of 5px:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the alignment of the middle bar of the loading indicator on the loading overlay and changes it to use flex instead of absolute positioning.
The indicator had a total height of 18px and in it three bars with a height of 3px each. This left 9px for margins split into 4px and 5px.
The indicator now has a height of 19px which leaves 10px for margins split evenly into 5px each.
Types of changes