Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Forward pass logic on snn.synaptic neuron fix #363

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix: Forward pass logic on snn.synaptic neuron fix #363

wants to merge 2 commits into from

Conversation

monkin77
Copy link

@monkin77 monkin77 commented Feb 2, 2025 •
edited
Loading

Fix bugs in snn.Synaptic forward pass. Mentioned in issues #358 #350 #349.

  1. Synaptic Current was being assigned to the wrong variable (self.syn = self.mem)
  2. The reset mechanism was not referencing the neuron's membrane potential variable properly (using mem instead of self.mem)

Pull Request #360 also takes care of the first issue so I included the original commit here

ignaciogavier and others added 2 commits January 23, 2025 20:53
@ignaciogavier
Update synaptic.py
5f404e6 
Fixed bug in forward method of Synaptic class when the argument syn is given.
@monkin77
Fix: Reference to self.mem on snn.Synaptic reset mechanism update
8f6ac76
This was referenced Feb 4, 2025
Closed
Closed
@stevenabreu7
Copy link
Collaborator

stevenabreu7 commented Feb 4, 2025 •
edited
Loading

this looks good to me, what do you think @jeshraghian (this fixes the NIR snnTorch conversion example)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@monkin77 @stevenabreu7 @ignaciogavier