2.1.0 - FontAwesome 4 Shim #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add a compatibilty class that includes FontAwesome 4 shim data from the FontAwesome metadata. * Effectively rewrite all instances of `fa-*` to their appropriate FontAwesome 5 font family. * Perform the icon key rewrite at the higest scope possible in `Prawn::Icon::Interface` to retain backwards compatibility. * Add a deprecation warning whenever `fa-*` references are encountered. * Disable the `Layout/IndentHeredoc` rubocop rule to not have to include further dependencies for heredoc indentation. * Bump version to 2.1.0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
shim data from the FontAwesome metadata.
fa-*to theirappropriate FontAwesome 5 font family.
in
Prawn::Icon::Interfaceto retain backwards compatibility.fa-*referencesare encountered.
Layout/IndentHeredocrubocop rule to nothave to include further dependencies for heredoc
indentation.
See the discussion here.