Expand the CI matrix to include recent versions of Prawn and Ruby #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addressed a number of Rubocop issues to get things green Added PDFs in the root to .gitignore to avoid accidentally committing rake legend output Bumped the minimum Ruby version in the gemspec to 2.6
|
Hey thanks @petergoldstein, I totally missed this! The PR looks great, I'll give it a look over in the next few days but we should be able to merge it! |
* Remove a few older/legacy versions of Prawn/Ruby from the CI Matrix. Going forward, let's plan on supporting the latest of Prawn 1.X, 2.X as well as Ruby 2.X and 3.X. * Lock rubocop to the current latest minor version and enable new cops. With the lock, we shouldn't get any sporadic CI failures. * Resolve all rubocop warnings, as well as remove a few exclusions that were no longer necessary, or we trivial to fix. * Don't use the safe navigation operator (and disable the rubocop check) as it constitutes a breaking change for some folks. SEE: #55
jessedoyle
approved these changes
Sep 1, 2022
| @@ -5,3 +5,4 @@ Gemfile.lock | |||
| coverage/ | |||
| vendor/bundle | |||
| .bundle | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds Prawn 2.4 and Ruby 3.1 the CI matrix.
This PR also: