Should now be able to use Material Design Icon font. #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @maneex - thanks so much for the contribution! This looks great! I'm going to push a commit or two to your branch to touch up a few minor things, but ultimately this is awesome - thanks again! |
jessedoyle
previously approved these changes
Sep 1, 2022
jessedoyle
force-pushed
the
feature/mdi
branch
from
658f307 to
c631024
Compare
* Add attribution for the author, thanks @maneex * Add a CHANGELOG entry for Material Design Icon use. * Bump the version to 3.1.0 - this is a non-breaking change. * Update documentation in the README to include the `mdi` namespace. * Add a test that explicitly references an MDI icon.
jessedoyle
force-pushed
the
feature/mdi
branch
from
c631024 to
42147c2
Compare
jessedoyle
approved these changes
Sep 1, 2022
jessedoyle
added a commit
that referenced
this pull request
Sep 1, 2022
Should now be able to use Material Design Icon font. Co-authored-by: Perceval <[email protected]>
jessedoyle
added a commit
that referenced
this pull request
Sep 1, 2022
Should now be able to use Material Design Icon font. Co-authored-by: maneex <[email protected]>
|
Thank you for this @maneex |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should allow to properly use Material Design Icon font (https://materialdesignicons.com/) with Prawn-icon.
Resolves: #58