Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Logs (and others) tab always being empty #241

Merged
merged 1 commit into from
Nov 13, 2020
Merged

Fix Logs (and others) tab always being empty #241

merged 1 commit into from
Nov 13, 2020

Conversation

tylerstillwater
Copy link
Contributor

@tylerstillwater tylerstillwater commented Oct 16, 2020 •
edited
Loading

Lazydocker was not flagging the docker logs process as a group, so the kill signal failed to kill all the children. As such, certain goroutines never exited, and the gui was unable to update or spawn new children.

Fixes #218 #239 #240

@lstolcman lstolcman mentioned this pull request Oct 28, 2020
Closed
@sfragata
Copy link

Hi @tylerstillwater you need to check why 2 check steps failed

@sfragata sfragata mentioned this pull request Oct 29, 2020
Closed
@tylerstillwater
Copy link
Contributor Author

Apparently gofmt -s didn't like the way my newlines were formatted.

@sfragata
Copy link

sfragata commented Nov 2, 2020

Seems good for me 👍

@sfragata
Copy link

@jesseduffield any news to review, merge and release this PR?

jesseduffield
jesseduffield approved these changes Nov 13, 2020
View reviewed changes
Copy link
Owner

@jesseduffield jesseduffield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jesseduffield
Copy link
Owner

Sorry for not getting around to this earlier, I completely missed it!

@jesseduffield jesseduffield merged commit ff0a53b into jesseduffield:master Nov 13, 2020
@dnv
Copy link

dnv commented Jan 17, 2021

The logs tab is still usually empty for me. Currently have 4 containers running, 1 shows logs, 3 don't.

lazydocker 0.10
Docker version 19.03.8

@tylerstillwater tylerstillwater deleted the fix-empty-logs branch May 13, 2021 19:42
@fellnerse
Copy link

For me its also still empty on:

Version: v0.12
Date:
BuildSource: Docker
Commit: c88fba5
OS: linux
Arch: amd64

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jesseduffield jesseduffield jesseduffield approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Logs tab is always empty
5 participants
@tylerstillwater @sfragata @jesseduffield @dnv @fellnerse