WIP: Adding split diff view with icdiff #161
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Maybe you could make it a setting, speaking of which a settings file / view could maybe be used for all sorts of things (for example colorscheme and language). With this it would be like or Design wise, it would look really crowded on smaller screens I suspect. |
|
Yeah that sounds good. I'll merge the user-config PR, then add this and make it explicit that you need icdiff installed for it to work |
jesseduffield
changed the title
|
closing in favour of #201 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm kinda tentative about this one. It looks awesome to have a split diff, but it's very slow. The only implementation that I could get working was one which used icdiff, meaning any user wanting to use that will need to install it separately. Given how slow it is, I don't think it should be used by default, and it sounds like a good candidate for a 'use split diff' user config value.
What are peoples' thoughts?
(the code as it is would need to actually add the configurable stuff, and I'll do that after the config PR gets merged - if we decide to go ahead with this)