Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use official AWS packages and allow custom endpoint #3

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

ThinkChaos
Copy link

I wanted to use this with a S3 compatible provider, so I made the required changes.
I also took the opportunity to change the AWS API to the official one.

P.S. I follow you on twitter and found this totally randomly, you do lots of cool and interesting things 😃

@tacerus
Copy link

tacerus commented Feb 24, 2021

Hi! Thanks a lot for this update, as I was trying to use s3server with a custom provider, and only realized after installing it that it was not possible. I cloned your forked repo and built it, and it worked great immediately. It is a real shame that the original developer did not approve your PR yet - I would suggest you go ahead and make your own forked project with it. If you do, please be so nice and remove the Google Tracking code from the HTML template - that's the only thing missing from making this perfect (well, there would be some more ideas from my end, but I'm happy it's working nicely so far). Again - Thank you for this patch, really appreciate it.

@ThinkChaos
Copy link
Author

@tacerus thanks for the kind words.
I'm using techknowlogick/caddy-s3browser nowadays. It's not for the exact same use-case as it is more like a standard file browser: it generates one page per directory.

This repo was updated since my PR so if you want to use it I think you should rebase (and remove the tracking if you so desire).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants