Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mutex the workers, to behave more like native jest test runs #5

Merged
merged 3 commits into from
Mar 27, 2018
Merged

Mutex the workers, to behave more like native jest test runs #5

merged 3 commits into from
Mar 27, 2018

Conversation

stipsan
Copy link
Contributor

@stipsan stipsan commented Mar 20, 2018

Makes the developer experience a bit nicer, and more like the jest-runner itself: https://github.com/facebook/jest/blob/e566a8f4106ac25b008744ffc42204554fd31cf6/packages/jest-runner/src/index.js#L104-L124

Here's an before/after using jest-runner-prettier on the jest repo itself using these settings:

module.exports = {
  displayName: 'Prettier',
  runner: 'jest-runner-prettier',
  moduleFileExtensions: ['md'],
  testMatch: [
    '**/*.md',
  ],
};

Before:
kapture 2018-03-20 at 22 43 54

After:
kapture 2018-03-20 at 22 46 03

Love this library btw 🎉 Great stuff 😄

@SimenB
Copy link
Member

SimenB commented Mar 22, 2018

Woo! This is great.

Note that #1 removes the throat dep, so you might want to re-add it if it's merged before this

@stipsan
Copy link
Contributor Author

stipsan commented Mar 22, 2018

Thanks for the heads up, I'll keep an eye out for it 😄

@keplersj
Copy link

I love that you used jest-runner-prettier for this. 😍

@skratchdot
Copy link
Contributor

@rogeliog - Any thoughts on this PR? I just recently started using your lib, but was looking for ways to make my custom runner output look a little more like the other runners I've used (less data in my scrollback history). This PR seems like it might do it.

Copy link
Member

@rogeliog rogeliog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome!

@rogeliog rogeliog merged commit c0b1f5f into jest-community:master Mar 27, 2018
@rogeliog
Copy link
Member

I just published 0.3.0 with this

@stipsan
Copy link
Contributor Author

stipsan commented Mar 27, 2018

@rogeliog great, thanks!!

@skratchdot
Copy link
Contributor

Nice work @rogeliog / @stipsan !! Trying this out now. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants