add useDashedArgs workspace setting #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connectdotz
reviewed
Jun 2, 2023
There was a problem hiding this comment.
@mjamin Thanks for the PR, it looked good. Just some minor suggestions for new test cases.
|
|
||
| const args = (createProcess: any).mock.calls[0][1]; | ||
| expect(args[0]).toBe(expected); | ||
| }); |
There was a problem hiding this comment.
let's add some test case to ensure user passed in args (options.args.args) will also be converted. Also add test cases to ensure if any of the arguments are already in dashed style, it will not be altered.
connectdotz
previously approved these changes
Jun 10, 2023
src/Runner.js
Outdated
| @@ -88,6 +88,16 @@ export default class Runner extends EventEmitter { | |||
| if (this.options.args) { | |||
| args.push(...this.options.args.args); | |||
| } | |||
| if (this.workspace.useDashedArgs) { | |||
| args.forEach((arg, index) => { | |||
There was a problem hiding this comment.
This code is not wrong, but usually, we use map for transformation operations. This might be more of a style and convention rather than correctness...
This was referenced Jun 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See this for context.