Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add typecheck script #254

Merged
merged 4 commits into from
Oct 11, 2021
Merged

Add typecheck script #254

merged 4 commits into from
Oct 11, 2021

Conversation

testerez
Copy link
Contributor

@testerez testerez commented Nov 29, 2019

Current typings are failing with @types/[email protected]

Here is the error you get:

node_modules/@types/jest/index.d.ts:729:15 - error TS2428: All declarations of 'Matchers' must have identical type parameters.

729     interface Matchers<R, T> {
                  ~~~~~~~~

types/index.d.ts:5:13 - error TS2428: All declarations of 'Matchers' must have identical type parameters.

5   interface Matchers<R> {
              ~~~~~~~~


Found 2 errors.

Changes:

  • Updated @types/[email protected]
  • Fixed /types/index.d.ts
  • Added a yarn typecheck to easily validate that typings are valid.

@codecov-io
Copy link

codecov-io commented Nov 29, 2019

Codecov Report

Merging #254 (53ab77d) into main (32afe6f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #254   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          125       125           
  Lines          774       774           
  Branches       115       115           
=========================================
  Hits           774       774           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32afe6f...53ab77d. Read the comment docs.

@buttilda
Copy link

buttilda commented Dec 3, 2019

This PR is a duplicate of: #235 which has been open since October... I don't think it's getting merged anytime soon. This project seems pretty abandoned

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@SimenB SimenB changed the title Bump @types/jest and add typecheck script Add typecheck script Oct 11, 2021
@SimenB SimenB merged commit 449905f into jest-community:main Oct 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants