Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: delete expect and jest-matcher-utils dependencies #405

Merged
merged 6 commits into from
Jan 28, 2022
Merged

feat: delete expect and jest-matcher-utils dependencies #405

merged 6 commits into from
Jan 28, 2022

Conversation

keeganwitt
Copy link
Collaborator

What

Don't depend on expect and jest-matcher-utils directly.

Why

utils are already injected into all the matchers.

Notes

Housekeeping

  • Unit tests
  • Documentation is up to date
  • No additional lint warnings
  • Typescript definitions are added/updated where relevant

@keeganwitt keeganwitt mentioned this pull request Jan 25, 2022
Closed
4 tasks
@codecov
Copy link

codecov bot commented Jan 25, 2022 •
edited
Loading

Codecov Report

Merging #405 (a0f1fb8) into main (524306c) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #405   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          137       137           
  Lines          843       853   +10     
  Branches       143       143           
=========================================
+ Hits           843       853   +10
Impacted Files Coverage Δ
src/matchers/toContainEntry/predicate.js 100.00% <ø> (ø)
src/matchers/toBeAfter/index.js 100.00% <100.00%> (ø)
src/matchers/toBeAfterOrEqualTo/index.js 100.00% <100.00%> (ø)
src/matchers/toBeArray/index.js 100.00% <100.00%> (ø)
src/matchers/toBeArrayOfSize/index.js 100.00% <100.00%> (ø)
src/matchers/toBeBefore/index.js 100.00% <100.00%> (ø)
src/matchers/toBeBeforeOrEqualTo/index.js 100.00% <100.00%> (ø)
src/matchers/toBeBetween/index.js 100.00% <100.00%> (ø)
src/matchers/toBeBoolean/index.js 100.00% <100.00%> (ø)
src/matchers/toBeDate/index.js 100.00% <100.00%> (ø)
... and 75 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 524306c...a0f1fb8. Read the comment docs.

@keeganwitt keeganwitt changed the title Upstream/keeganwitt/delete expect and jest matcher utils deps Delete expect and jest-matcher-utils dependencies Jan 25, 2022
mattphillips
mattphillips reviewed Jan 25, 2022
View reviewed changes
README.md Outdated Show resolved Hide resolved
@keeganwitt keeganwitt force-pushed the upstream/keeganwitt/delete_expect_and_jest-matcher-utils_deps branch 4 times, most recently from a06c5b3 to 23aa455 Compare January 26, 2022 23:50
@keeganwitt keeganwitt force-pushed the upstream/keeganwitt/delete_expect_and_jest-matcher-utils_deps branch from 23aa455 to e9e1f69 Compare January 27, 2022 13:01
SimenB
SimenB approved these changes Jan 28, 2022
View reviewed changes
Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#yolo

@SimenB SimenB changed the title Delete expect and jest-matcher-utils dependencies feat: delete expect and jest-matcher-utils dependencies Jan 28, 2022
@SimenB SimenB merged commit 98ef8c7 into jest-community:main Jan 28, 2022
@SimenB
Copy link
Member

SimenB commented Jan 28, 2022

https://github.com/jest-community/jest-extended/releases/tag/v2.0.0

Herculean PR @keeganwitt, thanks for persisting! 💪

@keeganwitt keeganwitt deleted the upstream/keeganwitt/delete_expect_and_jest-matcher-utils_deps branch January 29, 2022 05:23
kodiakhq bot referenced this pull request in X-oss-byte/Nextjs Oct 13, 2023
@renovate
Update dependency jest-extended to v4 (#370)
36166a3 
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [jest-extended](https://togithub.com/jest-community/jest-extended) | [`1.2.1` -> `4.0.2`](https://renovatebot.com/diffs/npm/jest-extended/1.2.1/4.0.2) | [![age](https://developer.mend.io/api/mc/badges/age/npm/jest-extended/4.0.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/jest-extended/4.0.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/jest-extended/1.2.1/4.0.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/jest-extended/1.2.1/4.0.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) |

---

### Release Notes

<details>
<summary>jest-community/jest-extended (jest-extended)</summary>

### [`v4.0.2`](https://togithub.com/jest-community/jest-extended/blob/HEAD/CHANGELOG.md#402)

[Compare Source](https://togithub.com/jest-community/jest-extended/compare/v4.0.1...v4.0.2)

##### Patch Changes

-   [`1f88101`](https://togithub.com/jest-community/jest-extended/commit/1f88101): Mark 2nd param of toHaveBeenCalledBefore and toHaveBeenCalledAfter optional

### [`v4.0.1`](https://togithub.com/jest-community/jest-extended/blob/HEAD/CHANGELOG.md#401)

[Compare Source](https://togithub.com/jest-community/jest-extended/compare/v4.0.0...v4.0.1)

##### Patch Changes

-   [`bad7056`](https://togithub.com/jest-community/jest-extended/commit/bad7056): Fix `toHaveBeenCalledExactlyOnceWith` typings
-   [`1609897`](https://togithub.com/jest-community/jest-extended/commit/1609897): Remove problematic Vitest types

### [`v4.0.0`](https://togithub.com/jest-community/jest-extended/blob/HEAD/CHANGELOG.md#400)

[Compare Source](https://togithub.com/jest-community/jest-extended/compare/v3.2.4...v4.0.0)

##### Major Changes

-   [`ab20845`](https://togithub.com/jest-community/jest-extended/commit/ab20845): Rename toHaveBeenCalledOnceWith to toHaveBeenCalledExactlyOnceWith

##### Minor Changes

-   [`5b80ca8`](https://togithub.com/jest-community/jest-extended/commit/5b80ca8): support vitest 0.31.0

##### Patch Changes

-   [`ab20845`](https://togithub.com/jest-community/jest-extended/commit/ab20845): Make CustomMatchers extend Record to fix a TypeScript error
-   [`ab20845`](https://togithub.com/jest-community/jest-extended/commit/ab20845): Fix toHaveBeenCalledOnceWith messages
-   [`ab20845`](https://togithub.com/jest-community/jest-extended/commit/ab20845): Change unknown to any in toHaveBeenCalledBefore and toHaveBeenCalledAfter

### [`v3.2.4`](https://togithub.com/jest-community/jest-extended/blob/HEAD/CHANGELOG.md#324)

[Compare Source](https://togithub.com/jest-community/jest-extended/compare/v3.2.3...v3.2.4)

##### Patch Changes

-   [`0b07513`](https://togithub.com/jest-community/jest-extended/commit/0b07513): Support varargs in toHaveBeenCalledOnceWith ([#&#8203;557](https://togithub.com/jest-community/jest-extended/issues/557))

### [`v3.2.3`](https://togithub.com/jest-community/jest-extended/releases/tag/v3.2.3)

[Compare Source](https://togithub.com/jest-community/jest-extended/compare/v3.2.2...v3.2.3)

#### What's Changed

-   fix(types): fix jest AsymmetricMatcher type by [@&#8203;rluvaton](https://togithub.com/rluvaton) in [https://github.com/jest-community/jest-extended/pull/551](https://togithub.com/jest-community/jest-extended/pull/551)

**Full Changelog**: jest-community/jest-extended@v3.2.2...v3.2.3

### [`v3.2.2`](https://togithub.com/jest-community/jest-extended/releases/tag/v3.2.2)

[Compare Source](https://togithub.com/jest-community/jest-extended/compare/v3.2.1...v3.2.2)

#### What's Changed

-   fix(types): add vitest support for AsymmetricMatchers by [@&#8203;rluvaton](https://togithub.com/rluvaton) in [https://github.com/jest-community/jest-extended/pull/549](https://togithub.com/jest-community/jest-extended/pull/549)

#### New Contributors

-   [@&#8203;rluvaton](https://togithub.com/rluvaton) made their first contribution in [https://github.com/jest-community/jest-extended/pull/549](https://togithub.com/jest-community/jest-extended/pull/549)

**Full Changelog**: jest-community/jest-extended@v3.2.1...v3.2.2

### [`v3.2.1`](https://togithub.com/jest-community/jest-extended/releases/tag/v3.2.1)

[Compare Source](https://togithub.com/jest-community/jest-extended/compare/v3.2.0...v3.2.1)

#### What's Changed

-   Change return type in Expect interface to void by [@&#8203;keeganwitt](https://togithub.com/keeganwitt) in [https://github.com/jest-community/jest-extended/pull/535](https://togithub.com/jest-community/jest-extended/pull/535)
-   Create pass/fail error messages only if required by [@&#8203;overlookmotel](https://togithub.com/overlookmotel) in [https://github.com/jest-community/jest-extended/pull/545](https://togithub.com/jest-community/jest-extended/pull/545)

#### New Contributors

-   [@&#8203;verdecchia](https://togithub.com/verdecchia) made their first contribution in [https://github.com/jest-community/jest-extended/pull/541](https://togithub.com/jest-community/jest-extended/pull/541)
-   [@&#8203;Unclemortuary](https://togithub.com/Unclemortuary) made their first contribution in [https://github.com/jest-community/jest-extended/pull/540](https://togithub.com/jest-community/jest-extended/pull/540)

**Full Changelog**: jest-community/jest-extended@v3.2.0...v3.2.1

### [`v3.2.0`](https://togithub.com/jest-community/jest-extended/releases/tag/v3.2.0)

[Compare Source](https://togithub.com/jest-community/jest-extended/compare/v3.1.0...v3.2.0)

#### What's Changed

-   Change return type in Expect interface from `Result` to `any` (closes [#&#8203;484](https://togithub.com/jest-community/jest-extended/issues/484)) by [@&#8203;keeganwitt](https://togithub.com/keeganwitt) in [https://github.com/jest-community/jest-extended/pull/492](https://togithub.com/jest-community/jest-extended/pull/492)
-   Fix `toHaveBeenCalledOnceWith` typing by [@&#8203;akoreh](https://togithub.com/akoreh) in [https://github.com/jest-community/jest-extended/pull/507](https://togithub.com/jest-community/jest-extended/pull/507)
-   Add `vitest` info to docs by [@&#8203;silverwind](https://togithub.com/silverwind) in [https://github.com/jest-community/jest-extended/pull/515](https://togithub.com/jest-community/jest-extended/pull/515)
-   Mark `jest` peerDependency as optional by [@&#8203;silverwind](https://togithub.com/silverwind) in [https://github.com/jest-community/jest-extended/pull/520](https://togithub.com/jest-community/jest-extended/pull/520)
-   `expect`: Add matcher `toBeInRange()` to validate if array elements are within the specified range by [@&#8203;mayankshukla94](https://togithub.com/mayankshukla94) in [https://github.com/jest-community/jest-extended/pull/461](https://togithub.com/jest-community/jest-extended/pull/461)
-   Fix `toHaveBeenCalledOnceWith` type definition (closes [#&#8203;518](https://togithub.com/jest-community/jest-extended/issues/518)) by [@&#8203;keeganwitt](https://togithub.com/keeganwitt) in [https://github.com/jest-community/jest-extended/pull/523](https://togithub.com/jest-community/jest-extended/pull/523)

#### New Contributors

-   [@&#8203;akoreh](https://togithub.com/akoreh) made their first contribution in [https://github.com/jest-community/jest-extended/pull/507](https://togithub.com/jest-community/jest-extended/pull/507)
-   [@&#8203;silverwind](https://togithub.com/silverwind) made their first contribution in [https://github.com/jest-community/jest-extended/pull/515](https://togithub.com/jest-community/jest-extended/pull/515)
-   [@&#8203;mayankshukla94](https://togithub.com/mayankshukla94) made their first contribution in [https://github.com/jest-community/jest-extended/pull/461](https://togithub.com/jest-community/jest-extended/pull/461)

**Full Changelog**: jest-community/jest-extended@v3.1.0...v3.2.0

### [`v3.1.0`](https://togithub.com/jest-community/jest-extended/releases/tag/v3.1.0)

[Compare Source](https://togithub.com/jest-community/jest-extended/compare/v3.0.2...v3.1.0)

#### What's Changed

-   Add toHaveBeenCalledOnceWith matcher by [@&#8203;thibautsabot](https://togithub.com/thibautsabot) in [https://github.com/jest-community/jest-extended/pull/430](https://togithub.com/jest-community/jest-extended/pull/430)
-   docs: mention `eslint-plugin-jest-extended` in README by [@&#8203;G-Rath](https://togithub.com/G-Rath) in [https://github.com/jest-community/jest-extended/pull/493](https://togithub.com/jest-community/jest-extended/pull/493)
-   Update jest monorepo to v29 (major) by [@&#8203;renovate](https://togithub.com/renovate) in [https://github.com/jest-community/jest-extended/pull/495](https://togithub.com/jest-community/jest-extended/pull/495)

#### New Contributors

-   [@&#8203;thibautsabot](https://togithub.com/thibautsabot) made their first contribution in [https://github.com/jest-community/jest-extended/pull/430](https://togithub.com/jest-community/jest-extended/pull/430)

**Full Changelog**: jest-community/jest-extended@v3.0.2...v3.1.0

### [`v3.0.2`](https://togithub.com/jest-community/jest-extended/releases/tag/v3.0.2)

[Compare Source](https://togithub.com/jest-community/jest-extended/compare/v3.0.1...v3.0.2)

#### What's Changed

-   Fix typings of `toThrowWithMessage`, support unconstructable errors by [@&#8203;GerkinDev](https://togithub.com/GerkinDev) in [https://github.com/jest-community/jest-extended/pull/475](https://togithub.com/jest-community/jest-extended/pull/475)
-   Fix toHaveBeenCalledBefore/toHaveBeenCalledAfter type definition by [@&#8203;aheuermann](https://togithub.com/aheuermann) in [https://github.com/jest-community/jest-extended/pull/292](https://togithub.com/jest-community/jest-extended/pull/292)
-   Declare matchers for use with expect.not.MATCHER ([#&#8203;385](https://togithub.com/jest-community/jest-extended/issues/385)) by [@&#8203;dharkness](https://togithub.com/dharkness) in [https://github.com/jest-community/jest-extended/pull/386](https://togithub.com/jest-community/jest-extended/pull/386)
-   Change any to unknown by [@&#8203;keeganwitt](https://togithub.com/keeganwitt) in [https://github.com/jest-community/jest-extended/pull/477](https://togithub.com/jest-community/jest-extended/pull/477)

#### New Contributors

-   [@&#8203;aheuermann](https://togithub.com/aheuermann) made their first contribution in [https://github.com/jest-community/jest-extended/pull/292](https://togithub.com/jest-community/jest-extended/pull/292)

**Full Changelog**: jest-community/jest-extended@v3.0.1...v3.0.2

### [`v3.0.1`](https://togithub.com/jest-community/jest-extended/releases/tag/v3.0.1)

[Compare Source](https://togithub.com/jest-community/jest-extended/compare/v3.0.0...v3.0.1)

#### What's Changed

-   fix: use `readonly` array types in matchers by [@&#8203;ilyub](https://togithub.com/ilyub) in [https://github.com/jest-community/jest-extended/pull/465](https://togithub.com/jest-community/jest-extended/pull/465)
-   fix(types): optional `failIfNoSecondInvocation` parameter by [@&#8203;j-waaang](https://togithub.com/j-waaang) in [https://github.com/jest-community/jest-extended/pull/468](https://togithub.com/jest-community/jest-extended/pull/468)

#### New Contributors

-   [@&#8203;ilyub](https://togithub.com/ilyub) made their first contribution in [https://github.com/jest-community/jest-extended/pull/465](https://togithub.com/jest-community/jest-extended/pull/465)
-   [@&#8203;j-waaang](https://togithub.com/j-waaang) made their first contribution in [https://github.com/jest-community/jest-extended/pull/468](https://togithub.com/jest-community/jest-extended/pull/468)

**Full Changelog**: jest-community/jest-extended@v3.0.0...v3.0.1

### [`v3.0.0`](https://togithub.com/jest-community/jest-extended/releases/tag/v3.0.0)

[Compare Source](https://togithub.com/jest-community/jest-extended/compare/v2.1.0...v3.0.0)

This is the same as https://github.com/jest-community/jest-extended/releases/tag/v2.1.0, but properly released as a major

### [`v2.1.0`](https://togithub.com/jest-community/jest-extended/releases/tag/v2.1.0)

[Compare Source](https://togithub.com/jest-community/jest-extended/compare/v2.0.0...v2.1.0)

⚠️ This should have been released as a major as it dropped Node 12 and 17 ⚠️

#### What's Changed

-   Restructure project by [@&#8203;mattphillips](https://togithub.com/mattphillips) in [https://github.com/jest-community/jest-extended/pull/410](https://togithub.com/jest-community/jest-extended/pull/410)
-   Fix broken link in example by [@&#8203;mattalexx](https://togithub.com/mattalexx) in [https://github.com/jest-community/jest-extended/pull/422](https://togithub.com/jest-community/jest-extended/pull/422)
-   Update toHaveBeenCalledAfter to fail if second mock is never called by [@&#8203;theryansmee](https://togithub.com/theryansmee) in [https://github.com/jest-community/jest-extended/pull/420](https://togithub.com/jest-community/jest-extended/pull/420)
-   Remove unsupported Node versions by [@&#8203;keeganwitt](https://togithub.com/keeganwitt) in [https://github.com/jest-community/jest-extended/pull/450](https://togithub.com/jest-community/jest-extended/pull/450)
-   chore(deps): lock file maintenance by [@&#8203;renovate](https://togithub.com/renovate) in [https://github.com/jest-community/jest-extended/pull/453](https://togithub.com/jest-community/jest-extended/pull/453)
-   chore(deps): lock file maintenance by [@&#8203;renovate](https://togithub.com/renovate) in [https://github.com/jest-community/jest-extended/pull/454](https://togithub.com/jest-community/jest-extended/pull/454)
-   Fix typos in matcherName in matcherHints by [@&#8203;keeganwitt](https://togithub.com/keeganwitt) in [https://github.com/jest-community/jest-extended/pull/457](https://togithub.com/jest-community/jest-extended/pull/457)
-   feat: upgrade to jest v28 by [@&#8203;G-Rath](https://togithub.com/G-Rath) in [https://github.com/jest-community/jest-extended/pull/463](https://togithub.com/jest-community/jest-extended/pull/463)

#### New Contributors

-   [@&#8203;mattalexx](https://togithub.com/mattalexx) made their first contribution in [https://github.com/jest-community/jest-extended/pull/422](https://togithub.com/jest-community/jest-extended/pull/422)
-   [@&#8203;theryansmee](https://togithub.com/theryansmee) made their first contribution in [https://github.com/jest-community/jest-extended/pull/420](https://togithub.com/jest-community/jest-extended/pull/420)
-   [@&#8203;G-Rath](https://togithub.com/G-Rath) made their first contribution in [https://github.com/jest-community/jest-extended/pull/463](https://togithub.com/jest-community/jest-extended/pull/463)

**Full Changelog**: jest-community/jest-extended@v2.0.0...v2.1.0

### [`v2.0.0`](https://togithub.com/jest-community/jest-extended/releases/tag/v2.0.0)

[Compare Source](https://togithub.com/jest-community/jest-extended/compare/v1.2.1...v2.0.0)

#### What's Changed

-   feat: delete expect and jest-matcher-utils dependencies by [@&#8203;keeganwitt](https://togithub.com/keeganwitt) in [https://github.com/jest-community/jest-extended/pull/405](https://togithub.com/jest-community/jest-extended/pull/405)

#### Breaking changes

-   Only `[email protected]` and newer is supported

**Full Changelog**: jest-community/jest-extended@v1.2.1...v2.0.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/X-oss-byte/Nextjs).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattphillips mattphillips mattphillips left review comments

@SimenB SimenB SimenB approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@keeganwitt @SimenB @mattphillips