Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restructure project #410
Restructure project #410
Changes from all commits
db62f1f
589ac34
8246b83
2a92a7b
5daecb1
39f303a
29ab13f
6dd14e6
f689d25
df3f191
225235d
b6e429c
f09acad
789f360
dbbcb7c
df87bc5
b948a9d
6b69371
7af5b38
fa1e3c1
3d1a693
8bc3771
20cea81
733ff39
b0a61a6
53f1999
72e5900
ab3eaf1
80ca51d
ab2fe38
62cf9f0
fc97d82
28b7733
dc22c14
c493e4d
e90bd3b
b8eed0f
5d975fb
2a97fbe
6274cab
e473dff
8518a22
32f2da6
010b514
af93ba1
d592f09
2c13b4f
e1e8dc4
add2912
e72c6d2
154cbd9
554eec7
d2c7a99
72b51cc
10c3077
cc8c80e
8288b41
2d54d92
0d9ec45
c2f40c7
ef78f50
c978845
2feb7f6
44e8f4f
209601e
8d62f8d
7493919
db7c0a5
39506a8
5dfbd60
a8a9850
800da58
b15ac5c
bb24d0a
410255e
1b160e4
f585c8b
f629315
e72dd14
dae7ff1
06c8051
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do we want this? seems likely to only cause confusion for most tools
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So that we can import from
src
in the test files assrc/
andtest/
are at the same level in the directory instead of having to add../..
to all imports.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
right, but is avoiding
../
worth breaking "go to definition" etc?I don't really have a strong opinion here (nor ownership 😀) but in the same way removing the
import.all
macro makes things not require specific tooling I don't think configuring the resolver of jest and eslint (and later typescript I assume) keeps the code base as approachable as possible.(if we want something like this, we should use https://nodejs.org/api/packages.html#subpath-imports or something that has an actual spec behind it instead of ad hoc config. That said, Jest does not support it (yet)).
Again, this is your project, not mine, so feel free to structure it how you want to 🙂 Just putting my opinion out there, because what else is the internet for?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love this 😆 your opinions are always welcome!
Tbh I setup all of my Typescript projects with the ability to import from
src
to make it easy to do absolute imports and move stuff around. With vscode at least (when using TS) importing fromsrc
doesn't breakgo to definition
, do you know if it does in other editors?I kind of see this PR as a precursor to switching to TS so hopefully the tooling will be better then.
This all probably stems from my Java days and when I work in Scala and being able to treat directories as packages/namespaces regardless of source set 😝
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've been writing Rust lately, so I feel this 😀
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.