feat: upgrade jest to v25 #83
Conversation
|
@ljharb Thx for the review. Looks like we'll need to remove node 6 support and update or remove node 8 support as well. :/ |
There was a problem hiding this comment.
@grxy that doesn't make sense to me, why would we have to do that?
travis shouldn't test jest 25 in node 6, of course, but that does not in any way mean that we need to drop node 6 support.
You should be able to add an exclude entry that prevents testing that version of jest.
We may also need to fix travis.yml so it tests all supported versions of jest, and not just the latest - that can be done with the matrix.
|
@ljharb That sounds good. I'll model it after how it's done for |
|
@ljharb After adding a full eslint x jest matrix, it turns out there are some dependency issues with older versions of jest (See https://travis-ci.org/jest-community/jest-runner-eslint/builds/640649231). Perhaps it would be more useful to the community to get a version out there that supports jest 25 (and dropping node 6/8 CI coverage temporarily), then following up with a deeper dive into a full jest x eslint CI matrix. What do you think? Or do you have a better approach to solving the matrix issue? |
| @@ -5,8 +5,7 @@ node_js: | |||
| - '8' | |||
| - '6' | |||
| install: | |||
| - 'if [ -n "${JEST}" ]; then yarn add --dev "jest@${JEST}" "babel-jest@${JEST}"; fi' | |||
| - 'if [ -n "${ESLINT}" ]; then yarn add "eslint@${ESLINT}"; fi' | |||
| - 'yarn add "eslint@${ESLINT}" "jest@${JEST}" "babel-jest@${JEST}"' | |||
There was a problem hiding this comment.
if this isn’t done conditionally, won’t it trigger on a future, say, linting build or similar? I suppose we could add the condition then too tho.
There was a problem hiding this comment.
My understanding of the build matrix is that these would always be defined in each build. Is this not the case, or are you speaking more to something that could be necessary in the future, but isn't right now?
There was a problem hiding this comment.
Most projects I've seen have an explicit include that runs eslint, since you don't need to run that more than once. My projects also have one for coverage, and one for npx aud for an audit check. This project doesn't seem to have that yet, however.
|
I just left my apartment, but I'll make a release when I get back home in a couple of hours. I'll also add @ljharb to the npm package, seems we've forgotten to do that 😬 |
|
Thanks, y'all! 🙏 |
No description provided.