Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove peer dependency on react-test-renderer #20

Closed
SimenB opened this issue Jan 11, 2018 · 1 comment
Closed

Remove peer dependency on react-test-renderer #20

SimenB opened this issue Jan 11, 2018 · 1 comment

Comments

@SimenB
Copy link
Member

SimenB commented Jan 11, 2018

I don't use React in my project, but I get a noisy peer dep warning from both npm and yarn when installing this module.

As it's optional, do you think you could drop it as a peer dep?

@thymikee
Copy link
Member

I'm supportive to that change. I'll tag it as a good first issue

Note to implementer:
The change requires us to put react-test-renderer call in a try/catch and throw some useful error when user tries to use it. We also need a test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants