fix(package): update jest dependencies #21
Conversation
| - "bar", | ||
| "baz", | ||
| + "quoz", | ||
| ] |
There was a problem hiding this comment.
@SimenB do you have any ideas on why do we have extra space in the snapshots?
There was a problem hiding this comment.
I'm not sure. It's a diff for jest 21. I'll see if I can isolate it
There was a problem hiding this comment.
It's this: jestjs/jest@7e2c206
/cc @pedrottimark
There was a problem hiding this comment.
Yes, that PR fixed a difference (pardon the pun :) between options:
expand: trueoutput a one-space “gutter” between -/+/space and content so content aligned with labels (seecan expand diff 1below)expand: falsedid not, but now it does, so the snapshot will not change if you toggle the option (for a diff which has fewer lines than the context)
| very | ||
| long | ||
| script | ||
| " |
There was a problem hiding this comment.
@thymikee This change is from jestjs/jest#4520:
expand: falseoption made sure that strings end with newlineexpand: truedid not, and in this case it even trimmed the newline at end of expected and received strings!
|
Thanks @SimenB @pedrottimark we'll need to mark it as breaking change then. |
|
@SimenB ping, we have a CI now 😉 thanks for reminding me about it |
Breaking change: indentation of diff has changed
| "strip-ansi": "^4.0.0" | ||
| }, | ||
| "devDependencies": { | ||
| "babel-cli": "^6.24.1", | ||
| "babel-preset-env": "^1.6.0", | ||
| "babel-preset-flow": "^6.23.0", | ||
| "babel-preset-react": "^6.24.1", | ||
| "eslint": "^4.3.0", | ||
| "eslint": "~4.13.0", |
There was a problem hiding this comment.
I deleted the lockfile to update all deps within semver, and without also updating eslint-config-callstack-io we are hit by the babel-eslint bug.
There was a problem hiding this comment.
We can update the eslint config in the followup PR though
|
I'm cool with next release to be a major, happy to see #20 as a part of it. I'll try to squeeze some time tomorrow or so to do some work (would also be cool to add more plugins by default, e.g. ReactTestComponent, not only ReactElement) |
|
@pedrottimark that's a valid point. We don't have a release schedule, so I'm ok with waiting a bit for the new release. WDYT @SimenB? |
|
It's annoying to see beta deps in my tree but there is no rush of course 🙂 |
|
I cannot reproduce the failing node 6 test locally 🙁. Is this travis and colors again? |
|
Looks like Travis being color blind again 🤷♂️ |
(mostly to not rely on beta releases)