-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document and test dontThrow for custom inline snapshot matchers #10995
Conversation
Codecov Report
@@ Coverage Diff @@
## master #10995 +/- ##
=======================================
Coverage 64.22% 64.22%
=======================================
Files 309 309
Lines 13519 13519
Branches 3294 3294
=======================================
Hits 8683 8683
Misses 4122 4122
Partials 714 714 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
could you add an entry to the changelog?
I didn't actually change any implementation. Or should I just add an entry like "Allow bailing out of failing tests with custom inline snapshot matchers"? |
Yeah, under |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
Closes #10888
Only documents it for inline snapshots since full snapshots would be reported as obsolete which isn't really ideal behavior. I guess ideally we could detect if obsolete snapshots are part of a test that failed and a note that they might not be obsolete after-all. For inline snapshots the current behavior with
dontThrow
looks ok to me.Test plan