[2] Press "u" to update snapshots from watch mode #1479
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xadn
force-pushed
the
watch-interactive
branch
from
2e30570 to
351a46e
Compare
xadn
force-pushed
the
watch-interactive
branch
from
351a46e to
4639222
Compare
Current coverage is 62.83% (diff: 2.08%)@@ master #1479 diff @@
==========================================
Files 96 96
Lines 3608 3635 +27
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 2284 2284
- Misses 1324 1351 +27
Partials 0 0
|
| @@ -63,6 +63,7 @@ class SnapshotFile { | |||
| this._content = Object.create(null); | |||
| if (this.fileExists(filename)) { | |||
| try { | |||
| delete require.cache[require.resolve(filename)]; | |||
|
This is super awesome. Would you mind rebasing it so I can merge it? Eventually we should move the watcher stuff into a separate file, but for now this is fantastic. |
This was referenced Aug 29, 2016
Closed
|
See #1508. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pressing "u" causes all failing snapshots to be updated. There is no way to select individual snapshots to update yet, but that's something we could think about for the future.
Note: this diff is based off of the changes for #1475, I'm not sure if there's a way to do stacked PRs.