-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement node Timer api when running in node environment. #4622
Merged
Merged
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
4bfff52
Implement node Timer api when running in node environment.
skrivle 22c673a
CR feedback, use toBeUndefined.
skrivle 48a129f
CR feedback, turn Faketimer constructor args into an object..
skrivle 8fe3228
tweak Faketimer tests, assert if ref/unref are actually functions.
skrivle File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
24 changes: 24 additions & 0 deletions
24
packages/jest-environment-jsdom/src/__tests__/jsdom_environment.test.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
/** | ||
* Copyright (c) 2014-present, Facebook, Inc. All rights reserved. | ||
* | ||
* This source code is licensed under the MIT license found in the | ||
* LICENSE file in the root directory of this source tree. | ||
*/ | ||
'use strict'; | ||
|
||
const JSDomEnvironment = require.requireActual('../'); | ||
|
||
describe('JSDomEnvironment', () => { | ||
it('should configure setTimeout/setInterval to use the browser api', () => { | ||
const env1 = new JSDomEnvironment({}); | ||
|
||
env1.fakeTimers.useFakeTimers(); | ||
|
||
const timer1 = env1.global.setTimeout(() => {}, 0); | ||
const timer2 = env1.global.setInterval(() => {}, 0); | ||
|
||
[timer1, timer2].forEach(timer => { | ||
expect(typeof timer === 'number').toBe(true); | ||
}); | ||
}); | ||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -27,4 +27,19 @@ describe('NodeEnvironment', () => { | |
|
||
expect(env1.global.global).toBe(env1.global); | ||
}); | ||
|
||
it('should configure setTimeout/setInterval to use the node api', () => { | ||
const env1 = new NodeEnvironment({}); | ||
|
||
env1.fakeTimers.useFakeTimers(); | ||
|
||
const timer1 = env1.global.setTimeout(() => {}, 0); | ||
const timer2 = env1.global.setInterval(() => {}, 0); | ||
|
||
[timer1, timer2].forEach(timer => { | ||
expect(timer.id).not.toBe(undefined); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
expect(timer.ref).not.toBe(undefined); | ||
expect(timer.unref).not.toBe(undefined); | ||
}); | ||
}); | ||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we make the constructor take an object instead of multiple arguments?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point! Updated.