Build on node 9 on Circle

[SimenB]

Summary
Node 9 is out, we should test on it.

Thoughts on doing full CI run on node 8, and partial on node 6? Node 8 is LTS now, and it should speed up the build somewhat

Test plan
Green CI

[codecov-io]

Codecov Report

Merging #4851 into master will decrease coverage by 0.57%.
The diff coverage is 25%.

@@            Coverage Diff             @@
##           master    #4851      +/-   ##
==========================================
- Coverage   60.74%   60.16%   -0.58%     
==========================================
  Files         198      198              
  Lines        6605     6620      +15     
  Branches        3        3              
==========================================
- Hits         4012     3983      -29     
- Misses       2593     2637      +44

Impacted Files	Coverage Δ
packages/jest-cli/src/generate_empty_coverage.js	85.71% <ø> (ø)	⬆️
packages/jest-runner/src/test_worker.js	0% <0%> (ø)	⬆️
packages/jest-cli/src/reporters/coverage_worker.js	81.81% <100%> (+31.81%)	⬆️
...ckages/jest-cli/src/reporters/coverage_reporter.js	65.38% <5.26%> (-0.76%)	⬇️
packages/jest-runner/src/index.js	38.29% <50%> (+0.52%)	⬆️
packages/jest-snapshot/src/index.js	43.18% <0%> (-19.87%)	⬇️
packages/jest-cli/src/pre_run_message.js	66.66% <0%> (-16.67%)	⬇️
packages/jest-util/src/index.js	88.23% <0%> (-2.25%)	⬇️
packages/jest-runtime/src/script_transformer.js	85.35% <0%> (-1.48%)	⬇️
... and 31 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25ed471...9c6f33b. Read the comment docs.

[SimenB]

Huh, weird failure

[cpojer]

Seems like assert's error was changed with node 9, so we have to make test work with both the old and new version.

[SimenB]

Ergh, unsure about the failure now. Seems like it just hung?

[thymikee]

Not a fan of this, but can live with it. Worth to refactor this test one day though.

[thymikee]

I re-ran the job, but locally I can confirm that running tests in parallel on Node 9 holds the Jest process (Node 8 kills it). Not sure if that's Node's fault, because running our test suite with --detectLeaks flag on @mjesun PR #4895 reveals a leak in our codebase (somehow connected with graceful-fs)

[SimenB]

Rebased on master and reverted the migration to jest-worker, just to test

[SimenB]

Didn't seem to help, hanging on the examples :(

[SimenB]

Easy reproduction of the error: ./jest --projects $(pwd)/examples/react-native. This passes on node 8 in 6 sec on my machine, hangs forever on node 9. I don't know why... I'm not sure what the best way to check why the process hangs is. #4895 doesn't help, as the tests never exit

[SimenB]

Is it related to react-native somehow? Might be a coincidence, but the linked issue from the node core issue tracker is also react-native. nodejs/node#17040

@cpojer I don't really know how to debug this, so a shot in the dark might be asking some react-native folks at fb if they know of any issues with node 9? Or if you have any ideas on how to figure out what's hanging, it would be much appreciated 🙂

[cpojer]

Is this using the latest version of RN? I'm assuming it doesn't reproduce locally?

[SimenB]

Running ./jest --projects $(pwd)/examples/react-native locally on node 9 reproduces the error

[SimenB]

Rebased now that #5050 is merged, fingers crossed! 🤞

[SimenB]

gah, these trailing spaces gets killed every time I rebase, and I keep forgetting to add them back in :P

[SimenB]

Node 9 is green, yay!

[cpojer]

Awesome!

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.