Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup from last review #5302

Merged
merged 2 commits into from
Jan 14, 2018
Merged

Cleanup from last review #5302

merged 2 commits into from
Jan 14, 2018

Conversation

rickhanlonii
Copy link
Member

Summary

@thymikee pointed out some bugs with the last PR that were missed before merge:

  • A test that was missing a flag
  • The blacklist would only work for the first key

Test plan

Updated tests to add a second blacklist key

@codecov-io
Copy link

Codecov Report

Merging #5302 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5302      +/-   ##
==========================================
- Coverage   61.25%   61.23%   -0.02%     
==========================================
  Files         205      205              
  Lines        6893     6891       -2     
  Branches        4        4              
==========================================
- Hits         4222     4220       -2     
  Misses       2670     2670              
  Partials        1        1
Impacted Files Coverage Δ
packages/jest-util/src/deep_cyclic_copy.js 95.83% <100%> (-0.33%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 09e47d6...b5774f1. Read the comment docs.

@SimenB SimenB requested a review from thymikee January 14, 2018 01:37
Copy link
Collaborator

@thymikee thymikee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yea, passing empty blacklist makes more sense than deleting from options, thanks for catching that! Cc @mjesun

@cpojer cpojer merged commit c9cf010 into jestjs:master Jan 14, 2018
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants