Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update istanbul-api #5637

Merged
merged 1 commit into from
Feb 22, 2018
Merged

update istanbul-api #5637

merged 1 commit into from
Feb 22, 2018

Conversation

aaronabramov
Copy link
Contributor

istanbul changed its reporting format.
This PR updates istanbul-api version and updates coverage snapshots

@codecov-io
Copy link

Codecov Report

Merging #5637 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5637   +/-   ##
=======================================
  Coverage   62.28%   62.28%           
=======================================
  Files         216      216           
  Lines        7898     7898           
  Branches        3        4    +1     
=======================================
  Hits         4919     4919           
  Misses       2978     2978           
  Partials        1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1203ed6...e09fcdf. Read the comment docs.

thymikee
thymikee reviewed Feb 22, 2018
View reviewed changes
yarn.lock
@@ -442,7 +442,20 @@ babel-eslint@^7.2.3:
babel-types "^6.23.0"
babylon "^6.17.0"

babel-generator@^6.18.0, babel-generator@^6.24.1, babel-generator@^6.26.0:
babel-generator@^6.18.0:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you edit lockfile by hand? This change is weird, ^6.18.0 should resolve to the same that ^6.24.1 and ^6.26.0 below

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yarn doesn't dedupe on upgrades (yarnpkg/yarn#3778)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, thanks!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(running yarn-tools to dedupe should be fine, fwiw)

@cpojer cpojer merged commit e9825d3 into jestjs:master Feb 22, 2018
@aaronabramov aaronabramov deleted the update-istanbul branch February 26, 2018 17:55
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@SimenB SimenB SimenB approved these changes

@thymikee thymikee thymikee approved these changes

Assignees
No one assigned
Labels
CLA Signed ✔️
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@aaronabramov @codecov-io @SimenB @thymikee @cpojer @facebook-github-bot