Bump required Node version and include note in docs #565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -35,6 +35,9 @@ We can get up and running with the following 4 steps: | |||
|
|
|||
| 2. Run `npm install jest-cli --save-dev` | |||
|
|
|||
| Jest uses modern JavaScript features (such as arrow-function) and requires a | |||
There was a problem hiding this comment.
Can you say "Jest uses ES2015 features and requires a Node.js version of at least 4.0.0 to run."? :)
- Bump the `engines` field in `package.json` to require at least a version `>= 4`. - Add a note to the "Getting Started"-guide to inform about the minimum required node version.
|
@facebook-github-bot shipit |
|
Thanks for importing. If you are an FB employee go to https://our.intern.facebook.com/intern/opensource/github/pull_request/1515284165460715/int_phab to review. |
ghost
closed this
in
|
I cannot do that @cpojer, because @clentfort does not have an active CLA on file. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
enginesfield inpackage.jsonto require at least a version>= 4.Node version. Fixes Requirements missing from documentation #563.