Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix snapshots #6113

Merged
merged 1 commit into from
May 2, 2018
Merged

Fix snapshots #6113

merged 1 commit into from
May 2, 2018

Conversation

mjesun
Copy link
Contributor

@mjesun mjesun commented May 2, 2018

A random snapshot is breaking, so we'll fix it by doing some replacements of space characters.

@@ -123,7 +123,7 @@ test('cannot test with no implementation', () => {
expect(status).toBe(1);

const {summary, rest} = extractSummary(stderr, {stripLocation: true});
expect(rest).toMatchSnapshot();
expect(rest.replace(/([\r\n])\s+(?=[\r\n])/g, '$1')).toMatchSnapshot();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

woah 😀

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😅

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If CI is happy, I'm happy

@mjesun
Copy link
Contributor Author

mjesun commented May 2, 2018

❤️

@SimenB
Copy link
Member

SimenB commented May 2, 2018

CI failed on lint :P

Appeyor is another test

@mattphillips mattphillips mentioned this pull request May 2, 2018
@mjesun mjesun merged commit ae691b1 into jestjs:master May 2, 2018
@mjesun mjesun deleted the fix-snapshots branch May 15, 2018 14:16
SimenB added a commit to SimenB/jest that referenced this pull request May 18, 2018
SimenB added a commit to SimenB/jest that referenced this pull request May 22, 2018
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants