Test Jest website build for every PR

[endiliey]

Summary

This is successor of #6590.

Changes:

1. CircleCI will try to build jest website when it is a PULL REQUEST instead of just skipping it. This is to ensure that there is nothing wrong with building the website
2. Use a safe getter function (inspired from Facebook idx function to access deeply nested values of an object)

Notice this

translation[this.props.language]['localized-strings'].tagline

This can cause build error which will return an unhandled promise. Currently jest use Docusaurus 1.3.0 which doesn't give non zero exit code when there is a build error. This is fixed in Docusaurus >= 1.3.1

Current local yarn build has an unhandled promise (build error)

Current website deploy has an unhandled promise (build error)
https://circleci.com/gh/facebook/jest/27857

Test plan

1. Ensure that yarn build has no more unhandled promise

2. Check this PR circleci run, should try to build the website for testing

https://circleci.com/gh/facebook/jest/27867

[endiliey]

If this PR got merged, the next step is to setup a netlify preview like Docusaurus.
cc @SimenB @thymikee

Example:

However, this can only be done by people with write access to facebook/jest. Docusaurus netlify preview is set up by @yangshun

[thymikee]

maybe we should call it just deploy-website

[endiliey]

I can change the name but is the naming okay ?

this PR implementation is

• if it is a push to branch (not a PR) -> deploy jestjs.io website
• if it is a PR -> test the static website build without deploying

[thymikee]

You're right, we should leave this naming

[codecov-io]

Codecov Report

Merging #6613 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #6613   +/-   ##
=======================================
  Coverage   63.73%   63.73%           
=======================================
  Files         235      235           
  Lines        8935     8935           
  Branches        4        4           
=======================================
  Hits         5695     5695           
  Misses       3239     3239           
  Partials        1        1

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6edbeb1...70488c7. Read the comment docs.

[SimenB]

I bet you need admin access to set it up - collaborators don't have access to bots or settings. Perhaps @JoelMarcey can do it for us?

[endiliey]

Oh right thats true. By the way Joel is on PTO for around 2 weeks since yesterday. I guess we'll have to wait

[yangshun]

Yes, admin access is required. We'd need Christoph or Joel to do it. Does @aaronabramov have admin access?

[JoelMarcey]

When I get to a computer, I can do this or give @yangshun temporary admin access to do this.

_{Sent with GitHawk}

[JoelMarcey]

@yangshun Ping me on messenger when you are online again, I can grant you access.

[rickhanlonii]

@JoelMarcey @yangshun can you force https while you're in the settings?

[JoelMarcey]

@rickhanlonii Just did that! 😄

[SimenB]

@endiliey any idea why all my PRs fail to deploy with netlify?

Failing build: Failed to prepare repo

See e.g. #6716

[endiliey]

@SimenB
I am not really sure, I don't have access to jest netlify. However, from the error, it suggests netlify not being able to clone from github.

https://app.netlify.com/sites/jest-preview/deploys/5b5090ffdd28ef7e1a118cde

9:24:15 PM: Build ready to start
9:24:16 PM: Fetching cached dependencies
9:24:16 PM: Starting to download cache of 346.4MB
9:24:18 PM: Finished downloading cache in 1.999510577s
9:24:18 PM: Starting to extract cache
9:24:23 PM: Finished fetching cache in 7.140422175s
9:24:23 PM: Starting to prepare the repo for build
9:24:24 PM: Preparing Git Reference pull/6716/head
9:24:26 PM: Failing build: Failed to prepare repo
9:24:26 PM: failed during stage 'preparing repo': exit status 1
9:24:26 PM: Finished processing build request in 9.606085246s

That PR #6716 also seems to have no relevant website files change

@yangshun any ideas ?

Edit:
Seems like it is caused by build cache error on netlify

I have cleared the build cache. It should work for the future build now

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.