Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CFP cleanup: Switch to manual checkpointing, tidy logging, expose further callback #123

Merged
merged 4 commits into from
Apr 12, 2019

Conversation

bartelink
Copy link
Collaborator

This PR results from work in the equinox-sync template in jet/dotnet-templates#19, consisting of:

  • Switch checkpointing to manual mode - because the default behavior of the processBatch function does not afford a way to inhibit the implicit writing of progress, the only viable solution is to turn it to manual mode
  • In order to enable a ChangeFeedObserver to log contextually, the wrapper will now decorate (and pass the decorated logger) with a partitionRangeId property
  • added contextual logging
  • exposed optional assign and revoke functions

@bartelink bartelink merged commit cc86a1b into master Apr 12, 2019
@bartelink bartelink deleted the cfp-fixes branch April 12, 2019 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant