Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reference to packed field is unaligned #7

Closed
wants to merge 3 commits into from
Closed

fix: reference to packed field is unaligned #7

wants to merge 3 commits into from

Conversation

Taowyoo
Copy link

@Taowyoo Taowyoo commented Apr 26, 2023

The main changes are in commit: fix: reference to packed field is unaligned
The other commit are code refactor to resolve some warning of deprecated macro or syntax.

@Taowyoo
Copy link
Author

Taowyoo commented Apr 26, 2023

@jethrogb could you help reivew this PR?

Copy link

@arai-fortanix arai-fortanix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like it changes public interfaces, so is this an incompatible change to the crate?

@Taowyoo
Copy link
Author

Taowyoo commented Apr 27, 2023

This looks like it changes public interfaces, so is this an incompatible change to the crate?

Yes, you are correct. Since I found the 0.2.0 is not published so I do not bump the version.
Will need some changes in https://github.com/fortanix/rust-sgx/blob/master/intel-sgx/sgxs-tools/src/bin/isgx-pe2sgx.rs for incompatible change here

@arai-fortanix
Copy link

I tried compiling this locally, and it also complained about the use of the bitflags! macro in src/types.rs using the deprecated try! macro. So the bitflags dependency also may need to be updated. That may require further source changes.

@arai-fortanix
Copy link

I'm wondering if we can just get rid of pe2sgxs though. Does anyone actually use it?

@Taowyoo

This comment was marked as outdated.

@Taowyoo
Copy link
Author

Taowyoo commented Apr 27, 2023

I tried compiling this locally, and it also complained about the use of the bitflags! macro in src/types.rs using the deprecated try! macro. So the bitflags dependency also may need to be updated. That may require further source changes.

If update bitflags! to new version: >=1.0.0, the the new bitflags use some refrence in it's macro which cause compile error

@Taowyoo Taowyoo closed this by deleting the head repository Dec 21, 2023
rlabrecque added a commit to rlabrecque/rl-diablo-2-hack that referenced this pull request Jan 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants