-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: reference to packed field is unaligned #7
Conversation
@jethrogb could you help reivew this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like it changes public interfaces, so is this an incompatible change to the crate?
Yes, you are correct. Since I found the |
I tried compiling this locally, and it also complained about the use of the |
I'm wondering if we can just get rid of |
This comment was marked as outdated.
This comment was marked as outdated.
If update |
…linjector locally and applied the changes from jethrogb/pe-rs#7
The main changes are in commit: fix: reference to packed field is unaligned
The other commit are code refactor to resolve some warning of deprecated macro or syntax.