Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add "webhook.hostNetwork" to helm chart #3163

Closed
shaunc opened this issue Aug 8, 2020 · 4 comments
Closed

add "webhook.hostNetwork" to helm chart #3163

shaunc opened this issue Aug 8, 2020 · 4 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@shaunc
Copy link

shaunc commented Aug 8, 2020

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is

https://cert-manager.io/next-docs/installation/compatibility/#aws-eks suggests using webhook with hostNetwork when using overlay network rather than AWS CNI. However, that is not available as an option for the helm chart.

Describe the solution you'd like
A clear and concise description of what you want to happen.

Add webhook.hostNetwork to helm chart options.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

manually edit webhook after deploy :(

Additional context
Add any other context about the feature request here.

Environment details (if applicable):

  • Kubernetes version (e.g. v1.10.2): v1.16
  • Cloud-provider/provisioner (e.g. GKE, kops AWS, etc): EKS / weave-net CNI
  • cert-manager version (e.g. v0.4.0): 0.15.2
  • Install method (e.g. helm or static manifests): helm

/kind feature

@jetstack-bot jetstack-bot added the kind/feature Categorizes issue or PR as related to a new feature. label Aug 8, 2020
@meyskens
Copy link
Contributor

meyskens commented Aug 8, 2020

You're looking at the documentation of release-next which is the documentation for our next release.
This feature got added in #3113 and will be released in v1.0

/close

@jetstack-bot
Copy link
Contributor

@meyskens: Closing this issue.

In response to this:

You're looking at the documentation of release-next which is the documentation for our next release.
This feature got added in #3113 and will be released in v1.0

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@shaunc
Copy link
Author

shaunc commented Aug 8, 2020

Thanks!

@tomi-bigpi
Copy link

In case anyone needs to get this applied before the 1.0 release, a command similar the following should do it:
kubectl patch deployment -n cert-manager cert-manager-webhook -p '{"spec":{"template":{"spec": {"hostNetwork":true}}}}'

We needed that for EKS controller to be able to connect to the webhook. Running that before trying to create the Issuers was required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

4 participants